fix: handle null ini values in phpini check#10233
Conversation
|
Hi there, Will-thom! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
|
@Will-thom Thank you for the PR. We require commits to be signed, please see this: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits Please also rebase to the latest |
paulbalandan
left a comment
There was a problem hiding this comment.
Please add one test in CheckPhpIniTest, and add a changelog entry
58964e7 to
3dafe0b
Compare
|
Addressed the requested follow-up: rebased onto latest develop, added CheckPhpIniTest coverage for null values returned by ini_get_all(), and added the v4.7.4 changelog entry. Local validation passed for PHP syntax on CheckPhpIni.php and CheckPhpIniTest.php, plus a Docker PHP smoke test for the null ini_get_all() path. A focused Composer/PHPUnit run was attempted but the local Docker/Composer install timed out, so CI remains the source of truth for the full PHPUnit run. |
|
@Will-thom Thank you for the update. We require all commits to be signed. Please follow these instructions: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits |
Refs #9968.
Summary
Tests